Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accounts hash calculation metrics #11433

Merged
merged 1 commit into from
Aug 7, 2020

Conversation

sakridge
Copy link
Member

@sakridge sakridge commented Aug 7, 2020

Problem

Not sure what is taking time in bank_forks:set_root

Summary of Changes

Add timing for hash calculation.

Fixes #

@sakridge sakridge force-pushed the accounts-hash-metrics branch from 7615b06 to 8a4a833 Compare August 7, 2020 00:25
@sakridge sakridge requested a review from carllin August 7, 2020 00:25
@carllin
Copy link
Contributor

carllin commented Aug 7, 2020

hehe beat me and @t-nelson to it, thanks!

carllin
carllin previously approved these changes Aug 7, 2020
@t-nelson t-nelson added the v1.2 label Aug 7, 2020
@sakridge sakridge force-pushed the accounts-hash-metrics branch from 8a4a833 to df4233d Compare August 7, 2020 00:52
@mergify mergify bot dismissed carllin’s stale review August 7, 2020 00:52

Pull request has been modified.

@t-nelson
Copy link
Contributor

t-nelson commented Aug 7, 2020

I picked this on top of v1.2.19 and it's running on the devnet validator, 47Sbuv6jL7CViK9F2NMW51aQGhfdpUu7WNvKyH645Rfi

@codecov
Copy link

codecov bot commented Aug 7, 2020

Codecov Report

Merging #11433 into master will decrease coverage by 0.0%.
The diff coverage is 100.0%.

@@            Coverage Diff            @@
##           master   #11433     +/-   ##
=========================================
- Coverage    81.9%    81.9%   -0.1%     
=========================================
  Files         320      320             
  Lines       75076    75082      +6     
=========================================
- Hits        61521    61507     -14     
- Misses      13555    13575     +20     

@sakridge sakridge merged commit 770d3d3 into solana-labs:master Aug 7, 2020
@sakridge sakridge deleted the accounts-hash-metrics branch August 7, 2020 04:39
mergify bot pushed a commit that referenced this pull request Aug 7, 2020
mergify bot added a commit that referenced this pull request Aug 7, 2020
(cherry picked from commit 770d3d3)

Co-authored-by: sakridge <sakridge@gmail.com>
@t-nelson t-nelson added the v1.3 label Aug 26, 2020
mergify bot pushed a commit that referenced this pull request Aug 26, 2020
@carllin carllin added v1.3 and removed v1.3 labels Aug 26, 2020
mergify bot added a commit that referenced this pull request Aug 26, 2020
(cherry picked from commit 770d3d3)

Co-authored-by: sakridge <sakridge@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants