-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accounts hash calculation metrics #11433
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakridge
force-pushed
the
accounts-hash-metrics
branch
from
August 7, 2020 00:25
7615b06
to
8a4a833
Compare
hehe beat me and @t-nelson to it, thanks! |
carllin
previously approved these changes
Aug 7, 2020
carllin
reviewed
Aug 7, 2020
sakridge
force-pushed
the
accounts-hash-metrics
branch
from
August 7, 2020 00:52
8a4a833
to
df4233d
Compare
I picked this on top of v1.2.19 and it's running on the devnet validator, 47Sbuv6jL7CViK9F2NMW51aQGhfdpUu7WNvKyH645Rfi |
Codecov Report
@@ Coverage Diff @@
## master #11433 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 320 320
Lines 75076 75082 +6
=========================================
- Hits 61521 61507 -14
- Misses 13555 13575 +20 |
mergify bot
pushed a commit
that referenced
this pull request
Aug 7, 2020
(cherry picked from commit 770d3d3)
mergify bot
pushed a commit
that referenced
this pull request
Aug 26, 2020
(cherry picked from commit 770d3d3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Not sure what is taking time in bank_forks:set_root
Summary of Changes
Add timing for hash calculation.
Fixes #